Zend internal changes: error handling and zend_make_compiled_string_description() takes in account lineno is uint32_t #20565
Conversation
some minor changes but above all trying to address the little concerns regarding errors bookkeeping.
|
It's often a good idea to choose a factor of 1.5, there's a mathematical reason behind it (https://github.com/facebook/folly/blob/main/folly/docs/FBVector.md#memory-handling). |
|
yes will try ; even though usage and growth might not be that as critical as your (nice) link contexts. |
Interesting, we currently extend arrays by a factor of 2, I wonder what would happen if we do 1.5 instead. |
Won't work because the hash masking depends on it being a power of 2. |
using just shift with integer rather than scalar integer to float conversion (shlr vs cvtsi2sd then mulsd on intel)
|
Can we get a clearer PR title? |
devnexen
changed the title
4 participants
No description provided.